fix: alias form model names so we do not get naming collisions #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tagged-release/cms-support #771 +/- ##
===========================================================
Coverage 92.02% 92.02%
===========================================================
Files 115 115
Lines 4387 4391 +4
Branches 1220 1221 +1
===========================================================
+ Hits 4037 4041 +4
Misses 329 329
Partials 21 21
Continue to review full report at Codecov.
|
scottyoung
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This changes handles the possibility of naming collisions within form relationships. Currently, the Studio Data Modeler will name the connected field
{ModelName}with a capital letter when creating abelongsTorelationship. Since this name would conflict with the model name/import, a collision happened. This is resolved by aliasing the model import toimport {ModelName} as {ModelName}0By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.